Skip to content

Removed attributes that are already available through composition #2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MennoVink
Copy link

@MennoVink MennoVink commented Nov 24, 2024

The extensions and extras attributes are not needed when glTFProperty has already been composited into the type.
Additionally name is not needed when compositing glTFChildOfRootProperty instead.
Attributes index and texCoord are not needed when textureInfo has already been composited into the type.

@javagl
Copy link
Contributor

javagl commented Nov 25, 2024

This is related to (and I think it implicitly fixes) #2420

@bghgary
Copy link
Contributor

bghgary commented Nov 25, 2024

Maybe check if this change works with glTF Tools for vscode, just in case.

@javagl
Copy link
Contributor

javagl commented Nov 26, 2024

^ This, but also check whether the output generated by https://github.com/CesiumGS/wetzel is still the same after the change (as this output is, in fact, a normative part of the spec...)

Copy link
Contributor

@aaronfranke aaronfranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, it's completely redundant to have these properties repeated in every schema. We should get rid of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants