Fix invalid README links - #414
Merged
Merged
Conversation
The root README file contains a table of all the lessons with links to the lesson source and solution files. The oneMath lesson features two versions of the source/solution files, one with USM and one with buffers with are distinguished in the filename. Therefore the `source.cpp` filename from the README table does not exist. I've fixed this by picking the USM variant of the lesson source/solution to link to from the root README.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root README file contains a table of all the lessons with links to the lesson source and solution files, some of these links are broken as files named
source.cppandsolution.cppdon't exist in the exercise directories.oneMath Lesson
The oneMath lesson features two versions of the source/solution files, one with USM and one with buffers with are distinguished in the filename. Therefore the
source.cppfilename from the README table does not exist.I've fixed the README link by picking the USM variant of the lesson source/solution to link to from the root README.
More SYCL Features
The "More SYCL Features" contains 4 files
reduce_naive/reduce_group_algorithm/reduce_sycl_reduction/reduce_atomic.cppwhich don't fix neatly in the source+solution paradigm, so I've just made the readme links point to the folder itself.