Fix bug in LessonChecker.py - #434
Merged
Merged
Conversation
TApplencourt
reviewed
Aug 3, 2026
TApplencourt
reviewed
Aug 3, 2026
MikeL270
added a commit
to MikeL270/syclacademy
that referenced
this pull request
Aug 3, 2026
* fix lesson checker bug then used it to fix image_convolution * remove stray tab, replace ignores with assertions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to fix a bug in the LessonChecker.py script where when a
<pre>and<code>tag are swapped and there is any kind of white space character other than\nbetween them like\tthe parser fails to swap the tags due to how it always checked the last member ofself.output, for a<code>tag, when in this case its actually one or more\tcharacters.I fixed the bug by having the parser use the
last_code_idxproperty. I introduced an appropriate test to prevent regression.This issue was discovered when image_convolution failed evaluation with LessonChecker.py. It correctly identified the issue, but auto fix failed to fix the issue since the last element of
self.outputwas\n\t\t\t\t...instead of the expected<code>. This PR also includes the autofixed image_convolution lesson.