Improve loading zone spawning

[MildlyInterested]

• no longer a distinction between spawnpoint or cratefiller base
• removed unused variables
• use KPCF_spawnRadius as area to spawn crates in

[Dubjunk]

There's an open todo in your comments, what's the exact problem you've to deal with?
Also why is the interact radius edited?

[MildlyInterested]

If findEmptyPosition fails and returns an empty array it won't spawn in the crate and will fail silently.
That same behaviour is present in v1.1.0 if the cratefiller base is used as spawn point so I haven't addressed it (yet).

As for the interact radius, that's a remnant of our mission framework changes, have reverted that.

[Dubjunk]

There was a check for it, which you've removed with your edits.

[MildlyInterested]

Do you mean: https://github.com/MildlyInterested/KP-Cratefiller/blob/720ff9b44f92fc90eca22c2ca78ab23dfd148ae9/KP-Cratefiller/KPCF/fnc/fn_spawnCrate.sqf#L40-L43 ?

That check only ran if the KPCF_cratefillerSpawn wasn't also the KPCF_cratefillerBase (https://github.com/MildlyInterested/KP-Cratefiller/blob/720ff9b44f92fc90eca22c2ca78ab23dfd148ae9/KP-Cratefiller/KPCF/fnc/fn_spawnCrate.sqf#L36-L38)

I've removed it because I didn't see a reason to treat spawning on KPCF_cratefillerBase or KPCF_cratefillerSpawn differently. findEmptyPosition should find a suitable spawn location either way.

[Dubjunk]

You're right, but it wouldn't be much work to implement a check for an empty array and exit with the same hint.

[MildlyInterested]

Commit is untested but how does that look for you?

[Dubjunk]

Should work as intended