Statically link the linux builds in actions. #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm... I'm not sure about this one. Statically linking also statically links any potential vulnerabilities, and I'm not sure if there are not any implicit kernel dependencies after all. If interoperability with WSL is the goal, I think building on a sufficiently old LTS version of Ubuntu would be a good solution. |
|
Yeah I thought you might prefer not merging this one haha, that's why I split the pull request to their components. I'll keep this open but feel free to close it! |
|
I've changed the runner to Ubuntu 22.04 in the master branch now. The result is at least compatible with a local WSL environment of that same version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While testing the linux builds generated through the current actions on WSL2, I ran into the following errors:
This is due to linking dynamically against the standard library, and causes portability issues that can be difficult to resolve on the user's side (this issue does not exist when built locally). Instead, this pr changes the linux build on actions to be statically linked for maximum portability.