Add compatibility to NC25 and NC26#61
Open
Oliv4945 wants to merge 11 commits into
Open
Conversation
Checked NC release notes from 22 to 24, tested it: compatibility is OK. Ran [PHP Compatibility](https://github.com/PHPCompatibility/PHPCompatibility): OK up to PHP version 8 .2 NC25 is not compatible because of SCSS changes
So renamed all Nextcloud component with NC prefix, see [here](nextcloud-libraries/nextcloud-vue#3058)
…lity As of NC25 application has to provide their own icons, see [here](nextcloud/server#32060) The switch to NcTextField allows easy to use their wrapper for the same result than previous code Use the MDI AccountSearchIcon which feels more appropriate than a simple magnifier
Seems that it has been there since e86dcc2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @alexhor, I made some changes to upgrade the plugin to current NC versions, I hope that you are still around to review and publish them, your app is very helpful to some of us :)
Please see the commits list for a summary of the changes, I am not familiar with Vue but everything should work. There is still some work required to avoid deprecation warning but I can tackle them later, same goes for a minor layout issue with the background (square vs new rounded NC policy)
Thanks