Skip to content

fix: add signature_of specialization for r-value references #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sangelovic merged 2 commits into from
Oct 23, 2025
+27 −0
Merged

fix: add signature_of specialization for r-value references #515

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
26576e5
test: add Variant move test
Oct 21, 2025
3b5fe1b
fix: provide signature_of<_T&&>
SimonBraunschmidtIBA Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions include/sdbus-c++/TypeTraits.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ namespace sdbus {
struct signature_of<_T&> : signature_of<_T>
{};

template <typename _T>
struct signature_of<_T&&> : signature_of<_T>
{};

template <>
struct signature_of<void>
{
Expand Down
23 changes: 23 additions & 0 deletions tests/unittests/Types_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,29 @@ TEST(AVariant, CanBeCopied)
ASSERT_THAT(variantCopy2.get<std::string>(), Eq(value));
}

TEST(AVariant, CanBeMoved)
{
auto value = "hello"s;
sdbus::Variant variant(value);

auto movedVariant{std::move(variant)};

ASSERT_THAT(movedVariant.get<std::string>(), Eq(value));
ASSERT_TRUE(variant.isEmpty());
}

TEST(AVariant, CanBeMovedIntoAMap)
{
auto value = "hello"s;
sdbus::Variant variant(value);

std::map<std::string, sdbus::Variant> mymap;
mymap.try_emplace("payload", std::move(variant));

ASSERT_THAT(mymap["payload"].get<std::string>(), Eq(value));
ASSERT_TRUE(variant.isEmpty());
}

TEST(AVariant, IsNotEmptyWhenContainsAValue)
{
sdbus::Variant v("hello");
Expand Down