fix: create sdbus::Error correctly when errno is 0 - #517
Merged
Conversation
JesseRiemens
suggested changes
Nov 6, 2025
Collaborator
Author
|
@JesseRiemens I addressed all your comments. Please re-review... |
JesseRiemens
approved these changes
Nov 6, 2025
JesseRiemens
left a comment
JesseRiemens
left a comment
There was a problem hiding this comment.
I'm happy with this, looks good to me!
sangelovic
force-pushed
the
fix/error-with-zero-errno
branch
from
November 12, 2025 13:56
f5d62be to
b65d589
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create an empty (invalid)
sdbus::Errorinstance when errno is 0, instead of segfaulting or throwing an exception bystd::string. Improve robustness ofsdbus::createError()in general. Add more tests.Fixes #516