[pull] master from PowerDNS:master#808
Merged
Merged
Conversation
Example:
local ips = {{}, {ip_dallas}}, {}, {ip_frankfurt}}
return ifurlup(url, ips, {selector='all', backupSelector='all'})
The previous behavior results in returning {ip_dallas, ip_frankfurt} if
every IP is detected as down. Health checks start out in the down state
so every IP is considered down after a server restart or changes to the
health check configuration. For GeoDNS configurations, this means GeoDNS
doesn't work when the service is first started or if health checks start
failing for every server due to a network or configuration issue.
This changes the behavior to returning {ip_dallas} when every IP is down
which matches the behavior when every IP is up. It makes much more sense
to have the same result for every IP being up and every IP being down.
Signed-off-by: Daniel Micay <daniel.micay@grapheneos.org>
…-262 requirements.txt: update version of pinned packages
The XSK map was not properly allocated, triggering a crash when trying to load a YAML configuration file with XSK support. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
dnsdist: Fix XSK configuration via YAML
We used to resize the vector instead of reserving memory, which is silly. It turns out that LuaWrapper cleaned up after us, but this was not nice. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
The counter was assigned in the loop instead of being added to. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
…reserve()` Same fix than in 0d45ff9 Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
If an incoming query has a very large EDNS OPT rdata length, but not the corresponding bytes, the existing code could have wrapped around to a small value after adding ECS. We would then send an invalid OPT record with some trailing bytes. The query would have been discarded by the backend but that's not very nice, let's drop it early AND make sure we don't wrap around. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
dnsdist: Compute a less inaccurate number of DNS records to pass to `reserve()`
dnsdist: Fix useless allocation in DNSQuestion:getProxyProtocolValues
dnsdist: Fix the dynamic block top suffixes counters computation
I _think_ the check was wrong, but please double-check my logic. Signed-off-by: Remi Gacogne <remi.gacogne@powerdns.com>
dnsdist: Fix OPT rdlen computation when adding ECS
auth: only apply backupSelector to the first non-empty group
ednscookies: Fix timestamp validity check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )