Skip to content

ComponentTransform should impl Default #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

adamchalmers
Copy link
Collaborator

@adamchalmers adamchalmers commented Apr 11, 2025

Default to no change, i.e. identity transform.

This way instead of writing

ComponentTransform {
    translate: myTranslate,
    rotate_rpy: None,
    rotate_angle_axis: None,
    scale: None,
}

you can just do

ComponentTransform {
    translate: myTranslate,
    ..Default::default()
}

Default to no change, i.e. identity transform.
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@3da8681). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #857   +/-   ##
=======================================
  Coverage        ?   24.86%           
=======================================
  Files           ?       36           
  Lines           ?     2192           
  Branches        ?        0           
=======================================
  Hits            ?      545           
  Misses          ?     1647           
  Partials        ?        0           
Flag Coverage Δ
unittests 24.86% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@adamchalmers adamchalmers merged commit 2189bb9 into main Apr 11, 2025
10 checks passed
@adamchalmers adamchalmers deleted the achalmers/transformby-default branch April 11, 2025 16:28
adamchalmers added a commit that referenced this pull request Apr 11, 2025
# Added

 - `ComponentTransform` impls `Default` (#857)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants