Skip to content

Adjust e2e step retries and timeouts #6374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

jacebrowning
Copy link
Collaborator

@jacebrowning jacebrowning commented Apr 17, 2025

Here's my logic for these changes:

  • step timeout should be just a bit longer than a "good" run
  • job timeout should be twice the step timeout to allow for one full rerun
  • we already increased the snapshot retries in ci: Add error to console exception #6392

Anything longer than this will likely be a real failure and is wasting our time and runner costs.

Copy link

qa-wolf bot commented Apr 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 21, 2025 3:48pm

Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (7a90d02) to head (c963820).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6374   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files         108      108           
  Lines       46280    46280           
=======================================
  Hits        39405    39405           
  Misses       6875     6875           
Flag Coverage Δ
rust 85.14% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant