-
Notifications
You must be signed in to change notification settings - Fork 61
Proposal: have left sidebar only contain Panes, split out Actions to right sidebar #6377
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: franknoirot/adhoc/appearance-tweaks-modeling-view
Are you sure you want to change the base?
Proposal: have left sidebar only contain Panes, split out Actions to right sidebar #6377
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## franknoirot/adhoc/appearance-tweaks-modeling-view #6377 +/- ##
==================================================================================
Coverage 85.06% 85.06%
==================================================================================
Files 108 108
Lines 46338 46338
==================================================================================
Hits 39417 39417
Misses 6921 6921
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Here are some relevant mockups I've been toying around with for panes. We have a different problem than IDEs because the buffers in an IDE are the main event, and while some dev-minded folks might disagree I'd argue it never is for us, but it really can eat up a lot of screen space, especially if we want to support buffers in the future. |
A few mono font points are left, mostly for numbers which look better in monospace.
"Never" is a strong word. I think there are legitimate use cases for all of these:
Ultimately, I think it has to be customizable. It's only a question of when. |
@jtran 's breakdown is an excellent reasoning behind why customization is useful: supporting more workflows. Unfortunately customization has its own costs to bring to life. Let's find the cheapest way to cover most cases. |
I agree with Jon's points. From an implementation stand point we could implement it based on those 4 points even if most people only use 2 of them. This gives us better flexibility in our workflows in the future. His bullet points are a perfect example of what is a dependency and what we would artificially make a dependency. |
Yeah @lee-at-zoo-corp I agree with you @jtran "never" is too strong of a word. Those are good examples of code-oriented user journeys, and good things to think of. |
This, along with @jtran's points, are good for future UI improvements. Can we open a discussion or issue about it? I don't think I can't rethink this layout responsibly before V1. Unless you all want to hop on a call together and hammer it out this week. |
… franknoirot/adhoc/split-sidebar
cff8939
to
43787b5
Compare
Currently our
ModelingSidebar
appears on the left side of the screen, and contains two lists of buttons:divided by a horizontal line.
Before:

After:

Here's my reasoning for this move:
One thing I don't like about this is that
Load external model
feels out on it's own, as it feels somewhat entangled with file tree actions, which contradicts my second point about conceptually separating these button types.I am okay with not doing this if you all don't like it, I don't think any of my reasoning points are insurmountable, I just have been thinking about final appearance changes to the app before V1, trying to identify the things that will cause the most user pain if we change them after we have users getting used to their workflows in the app, and I think moving the location of UI areas is a big one. So I want to either make this move or stick with the approach we have for the long-term if we can.