BREAKING: Change polygon to keyword args

[jtran]

Before

polygon({
  radius = 10,
  numSides = 6,
  center = [0, 0],
  inscribed = true,
}, %, $myTag)

After

polygon(
  radius = 10,
  numSides = 6,
  center = [0, 0],
  inscribed = true,
  tag = $myTag,
)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Apr 18, 2025 10:58pm

[qa-wolf]

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #6385 will not alter performance

_{Comparing jtran/kwargs-polygon (65072e6) with main (90acc00)}

Summary

✅ 54 untouched benchmarks

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.10%. Comparing base (90acc00) to head (65072e6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6385      +/-   ##
==========================================
- Coverage   85.11%   85.10%   -0.01%     
==========================================
  Files         108      108              
  Lines       46327    46324       -3     
==========================================
- Hits        39432    39426       -6     
- Misses       6895     6898       +3     

Flag	Coverage Δ
rust	85.10% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[adamchalmers]

Not really related to this PR, but: afaict from the body of the function, this sets the tag on every line in the polygon sketch. Probably not what we want! Should this even take a tag param at all?

[jtran]

WTF. It should probably not allow a tag. It might be okay if the tag could refer to the entire path, but I don't think we support that yet. I'll look into on Monday.

[adamchalmers]

Yeah. I think we should just remove this tag.

In the future we could consider allowing optional tags like (tagFace1 = $first, tagFace4 = $last)?