Skip to content

BREAKING: Change polygon to keyword args #6385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 21, 2025
Merged

BREAKING: Change polygon to keyword args #6385

merged 9 commits into from
Apr 21, 2025

Conversation

jtran
Copy link
Contributor

@jtran jtran commented Apr 17, 2025

Before

polygon({
  radius = 10,
  numSides = 6,
  center = [0, 0],
  inscribed = true,
}, %, $myTag)

After

polygon(
  radius = 10,
  numSides = 6,
  center = [0, 0],
  inscribed = true,
)

Note: tag is no longer supported.

@jtran jtran requested a review from adamchalmers April 17, 2025 21:25
Copy link

vercel bot commented Apr 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Apr 21, 2025 5:10pm

Copy link

qa-wolf bot commented Apr 17, 2025

QA Wolf here! As you write new code it's important that your test coverage is keeping up.
Click here to request test coverage for this PR!

Copy link

codspeed-hq bot commented Apr 17, 2025

CodSpeed Instrumentation Performance Report

Merging #6385 will not alter performance

Comparing jtran/kwargs-polygon (cd641bf) with main (790613e)

Summary

✅ 54 untouched benchmarks

Base automatically changed from chalmerstran/kwargs-arc2 to main April 18, 2025 22:40
Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.14%. Comparing base (7a90d02) to head (cd641bf).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6385   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files         108      108           
  Lines       46280    46269   -11     
=======================================
- Hits        39405    39396    -9     
+ Misses       6875     6873    -2     
Flag Coverage Δ
rust 85.14% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jtran jtran enabled auto-merge (squash) April 21, 2025 16:58
@jtran jtran merged commit f8ca6ad into main Apr 21, 2025
58 checks passed
@jtran jtran deleted the jtran/kwargs-polygon branch April 21, 2025 18:29
modeling-app-github-app bot pushed a commit that referenced this pull request Apr 21, 2025
* Change polygon to keyword args

* Update docs

* Update generated output

* Update docs to mention the default for inscribed

* Appease clippy

* Remove tag parameter

* Update docs since removing tag

* Remove inscribed from autocomplete snippet since the default is true
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants