WIP: #4852 Delete line segments in sketch mode using keyboard #6407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
QA Wolf here! As you write new code it's important that your test coverage is keeping up. |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Excited for this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Irev-Dev this is just a quick try to see how to approach this, it is almost working, but I wonder.. isn’t the main issue here that
modelingSend({ type: 'Delete selection' })is not handling the selected segments? Or is that only supposed to delete larger scoped items in the feature tree, like sketches?This PR just checks if the current selection is a segment and calls the segment specific
Delete Segmentcommand in that case..the reason it's not working yet is that the artifact is not found for segments just drawn, it is found when we exit and re-enter the sketch - probably the artifact graph needs to be refreshed.My other approach would be to add a hotkey listener in the React component where the current delete segment button UI is..but having one delete callback which deletes the current selection seems cleaner here.