integrate feature flag and async settings #9417

Irev-Dev · 2025-12-18T22:14:12Z

To verify this works, you can turn it on for yourself in dev with the admin dashboard go to
https://admin-dashboard-dev.hawk-dinosaur.ts.net/app/user?id=<YOUR_NAME>@zoo.dev
replace YOUR_NAME ofc.

Async Support for Settings hideOnPlatform with Feature Flag Integration (new_sketch_mode being the first one)

This PR adds support for async functions in the hideOnPlatform setting property, which lets us dynamically show or hide settings based on feature flags fetched from the API. The main use case is controlling the visibility of useNewSketchMode based on whether the user has the new_sketch_mode feature flag enabled. Because looking for feature flags is probably going to be the main usecase for the async setting, there's a function hideWithoutFeatureFlag('featureFlagName', 'both')

The implementation resolves async hideOnPlatform functions once during settings loading in loadAndValidateSettings(), then replaces the function with the resolved value. This makes everything synchronous after that point - all visibility checks, command bar registration, and React components work with sync values.

When settings are loaded via loadAndValidateSettings(), we call resolveAsyncHideOnPlatform() which collects all settings with async hideOnPlatform functions, resolves them in parallel, and replaces the function with the resolved value directly on the setting object. Since the settings object is the same reference used everywhere (including in the actor context), this single update makes everything work synchronously afterward.

The resolution happens once at startup, so all subsequent code (command bar registration, React components, etc.) can use sync helper functions without any async complexity.

Resolves #9277

CC @iterion

vercel · 2025-12-18T22:14:16Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
modeling-app	Ready	Preview, Comment	Dec 25, 2025 0:58am

iterion

I don't fully understand the react bits but as described this makes sense to me!

pierremtb · 2025-12-18T22:36:55Z

THE END OF IS_STAGING_OR_DEBUG FOR FEATURES IS NOW

Irev-Dev · 2025-12-18T22:37:40Z

src/lib/settings/initialSettings.tsx

        hideOnLevel: 'project',
-        // Don't show in prod, consider switching to use AdamS's endpoint https://github.com/KittyCAD/common/pull/1704
-        hideOnPlatform: IS_STAGING_OR_DEBUG ? undefined : 'both',
+        hideOnPlatform: hideWithoutFeatureFlag('new_sketch_mode', 'both'),


Hopefully this is all the diff we'll need for future feature flag settings.

Irev-Dev · 2025-12-18T22:38:54Z

src/lib/settings/initialSettings.tsx

+       * Otherwise, it will be hidden.
       */
      useNewSketchMode: new Setting<boolean>({
        hideOnLevel: 'project',


Oh shoot I think this is a copy paste from when I first added it, should this line be deleted?

Do we actually want to let people (us) turn it on only in some projects? Could make sense I guess?

Oh right, I really don't know. I definitely thought of it as a global thing, but maybe that's useful 🤷

Irev-Dev · 2025-12-18T22:43:02Z

src/lib/settings/initialSettings.tsx

+ * @returns An async function that resolves to the hideOnPlatform value
+ */
+function hideWithoutFeatureFlag(
+  featureFlagId: string,


Unfortunately the feature flag value itself is not part of the openAPI spec, so this is just a string that has to match the server's string.

Update:

not a blocker for this PR, just some follow up we could do.

Update update:

I changed this line to:
featureFlagId: UserFeatureEntry['id'],

Which still resolves to a string, but maybe will update to a union type if the spec updates.

Update update update:

Adam is already onto it.

https://github.com/KittyCAD/api/pull/3129/changes#diff-7dba33e298f3aa0823c3f9a3ada058d61db632b52c4300cf173d0720e9de78fa

pierremtb

Very excited for this. Just a few questions and notes! Until I get to test locally, might have to be a tomorrow thing

src/lib/commandBarConfigs/settingsCommandConfig.ts

src/lib/settings/initialSettings.tsx

pierremtb · 2025-12-18T22:47:03Z

src/lib/settings/initialSettings.tsx

+      // Try to get a token - check env first, then cookie for web
+      const envToken = env().VITE_ZOO_API_TOKEN
+      const cookieToken = getCookie()
+      const token = envToken || cookieToken || ''


Surprised to see this logic re-implemented here? Should we abstract out what's in useToken or whatever that hook is called?

Or is it because we need to make the call much earlier than when the auth machine gets it?

Oh I might be doing something wrong, though useToken is a hook right? I'm not sure if this createSettings is part of teh main react flow, looks like it gets called in singletons?

Yeah I agree @pierremtb that we can extract out that shared logic out of the useToken hook to a function that can be used useToken and in non-React contexts.

Since this function returns the defaultHide value if the token is not available, I think we could alternatively weave token through as an optional parameter into this function to move this client and token setup logic from here, and instead weave the token (value if it's available) through Router, routeLoaders, loadAndValidateSettings, and resolveAsyncHideOnPlatform, so we don't need to set up the client and get the token twice. But I don't think that needs to be done here, this is great.

How does fb5ab4f look?

pierremtb · 2025-12-18T22:49:09Z

src/lib/settings/initialSettings.tsx

+       * Otherwise, it will be hidden.
       */
      useNewSketchMode: new Setting<boolean>({
        hideOnLevel: 'project',


Do we actually want to let people (us) turn it on only in some projects? Could make sense I guess?

pierremtb · 2025-12-18T22:50:23Z

src/lib/settings/settingsTypes.ts

-  hideOnPlatform?: 'web' | 'desktop' | 'both'
+  hideOnPlatform?:
+    | HideOnPlatformValue
+    | (() => Promise<HideOnPlatformValue | null>)


Rando question for my own curiosity: why null v. undefined here for the promise return value?

Oh no reason. I never know how to decide between falsy values, I can change it if you like?

Co-authored-by: Pierre Jacquier <[email protected]>

Irev-Dev · 2025-12-18T23:50:09Z

e2e tests look related, having a look now.

pierremtb

Works great here, tested locally in the electron app and was able to see the setting based on where or not I had Force On enabled in the dev dashboard! This is huge

pierremtb · 2025-12-19T16:55:12Z

Only thing is I pinged @franknoirot on Slack, wondering if he has a good idea of where the api call should live since he's been deep in dependency injection in the last few weeks.

Not too concerned because this is only impacting an internal setting but would be best to set it up nicely as we'll quickly be building on it.

integrate feature flag

8f67005

Irev-Dev requested a review from a team as a code owner December 18, 2025 22:14

Irev-Dev added 2 commits December 19, 2025 09:20

remove dead code

b659b67

Merge remote-tracking branch 'origin' into kurt-9277-feature-flag

86d2845

Irev-Dev marked this pull request as draft December 18, 2025 22:25

self review

1afe78c

Irev-Dev marked this pull request as ready for review December 18, 2025 22:31

iterion approved these changes Dec 18, 2025

View reviewed changes

Irev-Dev commented Dec 18, 2025

View reviewed changes

vercel bot deployed to Preview December 18, 2025 22:46 View deployment

use type slight better than string

c96468f

pierremtb reviewed Dec 18, 2025

View reviewed changes

Update src/lib/settings/initialSettings.tsx

47cc2d6

Co-authored-by: Pierre Jacquier <[email protected]>

vercel bot deployed to Preview December 18, 2025 23:11 View deployment

Merge remote-tracking branch 'origin' into kurt-9277-feature-flag

31dce65

tweak

8cc1f17

vercel bot deployed to Preview December 19, 2025 03:01 View deployment

pierremtb approved these changes Dec 19, 2025

View reviewed changes

Irev-Dev added 2 commits December 25, 2025 11:43

extract token logic

fb5ab4f

Merge remote-tracking branch 'origin' into kurt-9277-feature-flag

1e38c84

vercel bot deployed to Preview December 25, 2025 00:58 View deployment

integrate feature flag and async settings #9417

Are you sure you want to change the base?

integrate feature flag and async settings #9417

Uh oh!

Conversation

Irev-Dev commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

iterion left a comment

Choose a reason for hiding this comment

Uh oh!

pierremtb commented Dec 18, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pierremtb left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Irev-Dev Dec 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Irev-Dev commented Dec 18, 2025

Uh oh!

pierremtb left a comment

Choose a reason for hiding this comment

Uh oh!

pierremtb commented Dec 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Irev-Dev commented Dec 18, 2025 •

edited

Loading

vercel bot commented Dec 18, 2025 •

edited

Loading

pierremtb left a comment •

edited

Loading

Irev-Dev Dec 25, 2025 •

edited

Loading

pierremtb commented Dec 19, 2025 •

edited

Loading