Decouple React and CodeMirror (v2) #9448
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
src/lang/KclManager.ts
Outdated
| this.setEditorView(viewUpdate.view) | ||
| } | ||
| const sceneEntitiesManager = this._sceneEntitiesManager | ||
| debugger |
Contributor
There was a problem hiding this comment.
A debugger statement is present in production code. This will cause the browser to pause execution when DevTools is open, breaking the application flow.
Fix: Remove this line:
// Remove the debugger statementSpotted by Graphite Agent
Is this helpful? React 👍 or 👎 to let us know.
franknoirot
force-pushed
the
franknoirot/8627/krc-2
branch
2 times, most recently
from
fc95c59 to
c57b4c9
Compare
franknoirot
force-pushed
the
franknoirot/8627/krc-2
branch
from
c57b4c9 to
d05a14c
Compare
franknoirot
force-pushed
the
franknoirot/8627/krc-2
branch
from
8f9d8e3 to
bbef9de
Compare
franknoirot
force-pushed
the
franknoirot/8627/krc-2
branch
from
bbef9de to
093c7cb
Compare
franknoirot
force-pushed
the
franknoirot/8627/krc-2
branch
from
4d1a705 to
03e201f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heavy rebase of #9190, testing out a competing approach to it. I believe this version has solved two major issues remaining in the other:
engineConnectionis started before allowing execution to occur. They were competing before, so theengineConnectionwould fire off an execution and it would say "I'm busy", then the zoom-to-fit would hit super early and not work right.