Skip to content

Enable open paths selection for surface lofts #9642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
pierremtb wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Enable open paths selection for surface lofts #9642

pierremtb wants to merge 3 commits into from

Conversation

@pierremtb
Copy link
Contributor

@pierremtb pierremtb commented Jan 13, 2026 •
edited
Loading

Closes #9592

Waiting on engine support, currently errors on Each UUID in sectionIds must refer to a closed path (Solid2D) for the following code

sketch001 = startSketchOn(XY)
profile001 = startProfile(sketch001, at = [-2.32, -2.09])
  |> line(end = [9.62, 4.63])
plane001 = offsetPlane(XY, offset = 5)
sketch002 = startSketchOn(plane001)
profile002 = startProfile(sketch002, at = [-0.75, -3.04])
  |> line(end = [8.17, 4.09])
loft001 = loft([profile001, profile002], bodyType = SURFACE)

This error is from https://github.com/KittyCAD/engine/blob/7130b98c4d0f1c75852db0adf8c520145b44b67e/cpp/engine/scene/scene.cpp#L2232

@vercel
Copy link

vercel bot commented Jan 13, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
modeling-app Ready Ready Preview, Comment Jan 14, 2026 2:07pm

pierremtb
pierremtb commented Jan 14, 2026
View reviewed changes
src/lang/modifyAst/sweeps.spec.ts
Comment on lines +828 to +829
if (!loft || loft.type !== 'StdLibCall') throw new Error('Op not found')
expect(loft.isError).toBeFalsy()
Copy link
Contributor Author

@pierremtb pierremtb Jan 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing now, expected to pass once https://github.com/KittyCAD/engine/pull/4088 is in

@pierremtb pierremtb mentioned this pull request Jan 14, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable open paths selection for surface lofts

2 participants

@pierremtb