ZDS support for Flip Surface #9695
Open
+383
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #9683 Left a few TODOs on this one @max-mrgrsk. Need to think about a few things like if it should be in a new group, icon, etc.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
max-mrgrsk
requested changes
Jan 17, 2026
Contributor
max-mrgrsk
left a comment
max-mrgrsk
left a comment
There was a problem hiding this comment.
Ty, this looks great.
- @franknoirot could you design this icon so we don’t need to revisit it later?
-
@pierremtb I think KCL should support multiple selections here. Do you think we should merge now and follow up, or wait until that’s implemented?
-
@adamchalmers it’d be great if KCL supported multiple selections for this - usually you want to flip more than one thing at a time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9683
Only TODOs left are to update the operation and toolbar icons to something unique, not just rotate. Probably fine for now though!