[SOLVE] Better integrate Sketch Block and Constraints in the Feature Tree #9712
+251
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te all sketch icons from Figma Towards #9268
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pierremtb
changed the title
pierremtb
changed the title
pierremtb
changed the title
This was
linked to
issues
Jan 16, 2026
pierremtb
changed the title
pierremtb
commented
Jan 16, 2026
Comment on lines
+157
to
+187
| // Sketch Solve Constraint case | ||
| const sketchBlock = getNodeFromPath<SketchBlock>( | ||
| astClone, | ||
| selection.codeRef.pathToNode, | ||
| wasmInstance, | ||
| 'SketchBlock' | ||
| ) | ||
| if (!err(sketchBlock) && sketchBlock.node.type === 'SketchBlock') { | ||
| const isItemInSketchBlock = | ||
| sketchBlock.deepPath.length > sketchBlock.shallowPath.length | ||
| const itemsIndex = -2 // index of items in body is second to last | ||
| const nodeIndex = sketchBlock.deepPath.at(itemsIndex)?.[0] | ||
| if ( | ||
| isItemInSketchBlock && | ||
| typeof nodeIndex === 'number' && | ||
| sketchBlock.node.body.items[nodeIndex] !== undefined | ||
| ) { | ||
| sketchBlock.node.body.items.splice(nodeIndex, 1) | ||
| return astClone | ||
| } | ||
|
|
||
| // Whole sketch block deletion case | ||
| if ( | ||
| typeof nodeIndex === 'number' && | ||
| astClone.body[nodeIndex] !== undefined | ||
| ) { | ||
| astClone.body.splice(nodeIndex, 1) | ||
| return astClone | ||
| } | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Just one more case 😬
Contributor
Author
There was a problem hiding this comment.
We surely can move this new deletion case to Rust, but I feel like this is something we could do all at once once we move there?
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9268 and #9269
In this PR: