Skip to content

Replace win-ca with node:tls snippet #9717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
pierremtb wants to merge 1 commit into
base: pierremtb/electron-v40
Choose a base branch
from
+13 −7
Draft

Replace win-ca with node:tls snippet #9717

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion electron-builder.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ directories:
buildResources: assets
files:
- .vite/**
- "!node_modules/win-ca/pem/**"
mac:
category: public.app-category.developer-tools
artifactName: "${productName}-${version}-${arch}-${os}.${ext}"
Expand Down
12 changes: 9 additions & 3 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
"vscode-uri": "^3.1.0",
"web-vitals": "^3.5.2",
"why-is-node-running": "^3.2.2",
"win-ca": "^3.5.1",
"xstate": "^5.19.2",
"yargs": "^17.7.2"
},
Expand Down
6 changes: 4 additions & 2 deletions src/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,12 @@ import {
} from '@src/menu'
import { getAutoUpdater } from '@src/updater'
import type { ModuleType } from '@src/lib/wasm_lib_wrapper'
import { globalAgent } from 'https'
import { getCACertificates } from 'node:tls'

// If we're on Windows, pull the local system TLS CAs in
require('win-ca')
console.log('process.versions', process.versions)
// Pull the local system TLS CAs in (like with win-ca in the past)
globalAgent.options.ca = getCACertificates('system')

let mainWindow: BrowserWindow | null = null
/** All Electron windows will share this WASM module */
Expand Down
Loading