Artifact graph: add link between Sweep::Sweep and trajectory Path or Helix, add Helix from Cylinder to Artifact Graph
#9724
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
Footnotes
|
| match trajectory_artifact { | ||
| Artifact::Path(path) => { | ||
| let mut new_path = path.clone(); | ||
| new_path.sweep_id = Some(id); |
There was a problem hiding this comment.
Do we want to do this? It kind of overloads the path's sweep_id to mean both that the path was swept and that it was swept along.
There was a problem hiding this comment.
Oh okay so would it be more prudent to add a new field that indicates the relationship is a trajectory specifically? The name sweep_id was already ambiguous to indicate a path was used as th profile to be swept imo
There was a problem hiding this comment.
I think it's more accurately modeling what's happening if we used a new field, yeah. But it all depends on how it's used, which I don't know.
Sweep::Sweepfrom other Sweep subtypes in ModelingCmd-to-Artifact match, so thattrajectorycan be peeled off and a link can be made fromSweep::Sweep's to theirPathorHelixtrajectoryDemo
In the screenshot below you can see that the artifact graph now shows this Helix that was both created from a cylinder and used in a subsequent Sweep has both a valid
axis_idand a valid (new)sweep_id.