Conversation
weissi
reviewed
Jan 22, 2020
| Log.error("Failed to send error response") | ||
| } | ||
| context.close() | ||
| _ = context.close() |
There was a problem hiding this comment.
if you use context.close(promise: nil), then that's more efficient and doesn't return anything so you don't need the _ =
|
|
||
| let bootstrap = ServerBootstrap(group: eventLoopGroup) | ||
| .serverChannelOption(ChannelOptions.backlog, value: BacklogOption.Value(self.maxPendingConnections)) | ||
| .serverChannelOption(ChannelOptions.backlog, value: ChannelOptions.Types.BacklogOption.Value(self.maxPendingConnections)) |
There was a problem hiding this comment.
use ChannelOptions.backlog, that works in all NIO versions. The Types are more or less internal
weissi
reviewed
Jan 22, 2020
| @@ -93,7 +93,7 @@ internal class HTTPRequestHandler: ChannelInboundHandler, RemovableChannelHandle | |||
| } catch { | |||
There was a problem hiding this comment.
you also need to bump the minimum NIO version in Package.swift to from: "2.12.0" because you're using new stuff from 2.12
Contributor
Author
|
Thanks for reviewing @weissi ! I've addressed your comments. |
|
Pushkar Kulkarni seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.