Adds username AUTH, disconnect methods. #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
scuml
commented
Oct 14, 2020
scuml
commented
- Adds AUTH with username support
- Adds redis.disconnect()
|
Kudos, SonarCloud Quality Gate passed!
|
mbarnach
requested changes
Oct 15, 2020
Member
mbarnach
left a comment
mbarnach
left a comment
There was a problem hiding this comment.
If you could add a test of the new function, it would be nice.
Could you explain why you change the visibility of the RedisResp class, even if nothing is public inside?
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.