Merge pull request #1096 from Kitware/fix_undefined_var

zackgalbreath · web-flow · commit 0c5e3ab8e8fd · 2020-11-13T11:29:00.000-05:00
Define $status even when an exception gets thrown
diff --git a/app/cdash/include/Messaging/Notification/Email/Mail.php b/app/cdash/include/Messaging/Notification/Email/Mail.php
@@ -132,6 +132,7 @@ public function send(EmailMessage $message)
         try {
             $status = $swift_mailer->send($swift_message, $failed_recipients);
         } catch (\Exception $e) {
+            $status = 0;
             $log = Log::getInstance();
             $log->add_log($e->getMessage(), __METHOD__);
         }

Original file line number	Diff line number	Diff line change
`@@ -132,6 +132,7 @@ public function send(EmailMessage $message)`
`132`	`132`	`try {`
`133`	`133`	`$status = $swift_mailer->send($swift_message, $failed_recipients);`
`134`	`134`	`} catch (\Exception $e) {`
	`135`	`+ $status = 0;`
`135`	`136`	`$log = Log::getInstance();`
`136`	`137`	`$log->add_log($e->getMessage(), __METHOD__);`
`137`	`138`	`}`