Skip to content

Use common Blade template for Vue-only pages #2880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2025

Conversation

williamjallen
Copy link
Collaborator

Most Vue pages are fully contained within a single Vue component wrapped in a short Blade template. This PR addresses the common Vue use case by creating a shared method which handles injecting a Vue component and associated props. Doing so improves safety in the boundary between PHP and Vue props because Blade templates aren't scanned by our static analysis tools.

Copy link
Member

@josephsnyder josephsnyder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! No issues found in brief manual exploration of test data on display.

@josephsnyder josephsnyder added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@williamjallen williamjallen added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@williamjallen williamjallen added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@williamjallen williamjallen added this pull request to the merge queue May 12, 2025
Merged via the queue into Kitware:master with commit 113b418 May 12, 2025
25 of 27 checks passed
@williamjallen williamjallen deleted the vue-blade-template branch May 12, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants