Skip to content

fix(LayerProperties): handle long layer names#479

Merged
floryst merged 1 commit into
Kitware:mainfrom
PaulHax:layer-names
Nov 8, 2023
Merged

fix(LayerProperties): handle long layer names#479
floryst merged 1 commit into
Kitware:mainfrom
PaulHax:layer-names

Conversation

@PaulHax

@PaulHax PaulHax commented Nov 3, 2023

Copy link
Copy Markdown
Collaborator
  • Long layer names were squishing the opacity slider horizontally to nothing.
  • For DICOM sourced layers, use datasets-image name for layer name.

image

Will address #462 when this change lands:
https://github.com/Kitware/VolView/pull/444/files#diff-2e48f469094ddae541596589e83ce73d782a438463fffc512e952d1aedd57b73L361-R372

@netlify

netlify Bot commented Nov 3, 2023

Copy link
Copy Markdown

Deploy Preview for volview-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit b3bd269
🔍 Latest deploy log https://app.netlify.com/sites/volview-dev/deploys/6546686e92fb7f000824dd83
😎 Deploy Preview https://deploy-preview-479--volview-dev.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

* Long layer names were squishing the opacity slider horizontally to nothing.
* For DICOM sourced layers, use datasets-image name for layer name.
@aylward

aylward commented Nov 5, 2023

Copy link
Copy Markdown
Contributor

When using the CT and 2 SEG data from #482

The layer name is not short and hard to match with input data

image image

@PaulHax

PaulHax commented Nov 6, 2023

Copy link
Copy Markdown
Collaborator Author

The layer name is not short and hard to match with input data

This will be fixed when #444 and this PR are merged.

@floryst

floryst commented Nov 6, 2023

Copy link
Copy Markdown
Contributor

LGTM!

@floryst floryst added this pull request to the merge queue Nov 8, 2023
Merged via the queue into Kitware:main with commit c0296b8 Nov 8, 2023
PaulHax pushed a commit to PaulHax/VolView that referenced this pull request Apr 24, 2025
fix(LayerProperties): handle long layer names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants