-
Notifications
You must be signed in to change notification settings - Fork 1
Add secondary fixed axis display #252
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BryonLewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this, just a few minor things that mostly have to do with the scaling of text.
The Midpoint text gets mixed up with the endpoints based on the zoom level and the data:

Maybe offset the mid-points, higher up than the start/end in the compressed view so they don't run into each other.
When zoomed out completely there is also text that is overwriting items.

I know that in the standard view I think I did something with text scaling as the user zooms out to reduce text size so that the elements are still there but are smaller.
This issue with the text also applies to the X-Scaling. I.E if you are in the compressed view we default to an X-Scaling of 2.5 but it can reduce back to 1 (using ctrl+scroll). As it reduces I make the size smaller and then will hide the text if it gets too small (below 1.5x).
|
Text scaling has been added by inheriting from |
I think you may need to add something for X-scaling (ctrl+scroll) as well. Maybe hiding the display once you get below 1.5X size or so or reducing the text size more. |
Fixed by looking at the existing Also updated the threshold for showing midpoints to compare number of visible segments to a constant. Previously if a spectrogram had many many segments in the compressed view, the midpoints would show up at the default zoom level, which subjectively looked too busy. |
BryonLewis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks good, thanks.
Adds an additional layer to handle axes that are fixed to the edges of the GeoJS viewer. Supports features like:
Adds state management to toggle between current axes implementation (default) or fixed axes.