Remove dead code from DRF #302
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianhelba
commented
Jan 15, 2026
| from resonant_settings.django_extensions import * | ||
| from resonant_settings.logging import * | ||
| from resonant_settings.oauth_toolkit import * | ||
| from resonant_settings.rest_framework import * |
Member
Author
There was a problem hiding this comment.
While most of this file isn't needed, it does also configure some Django-specific settings which relate to authentication and security.
How does BatAI authenticate API requests currently (cookies, OAuth2, etc.)? Do you use the same authentication for both the Ajax requests from the SPA and for using the Swagger docs (or do you not use the Swagger docs at all)? I want to make sure Ninja stays configured appropriately and securely.
This is currently causing import errors in `urls.py`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is currently causing import errors in
urls.py.