fix(cache): clean cache on object deletion#114
Merged
Merged
Conversation
finetjul
reviewed
May 21, 2026
Member
finetjul
left a comment
finetjul
left a comment
There was a problem hiding this comment.
Could you explain how to reproduce cache corruption (a unit test if systematically reproducible would be even better)
Contributor
Author
The only reproducible test I have is in trame-pyvista, should I still document it here ? |
Member
Referencing the PyVista issue is a must. |
Remove cached properties of deleted objects to reduce cache size and prevent cache corruption
Contributor
Author
jourdain
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove cached properties of deleted objects to reduce cache size and prevent cache corruption
Fixes lookup table errors referenced in this issue
Prevent a cache registered for a previous object being used for another object with a same key.