refactor(Rendering): extract ScalarColoring into a helper - #3561
Merged
Conversation
daker
force-pushed
the
refactor-scalarcoloring
branch
3 times, most recently
from
July 21, 2026 09:18
7a52572 to
08c6718
Compare
daker
marked this pull request as ready for review
July 21, 2026 15:35
finetjul
reviewed
Jul 21, 2026
finetjul
left a comment
finetjul
left a comment
Member
There was a problem hiding this comment.
Why not calling it a helper ? (like CoincidentTopologyHelper)
You might want to "factorize" the correspdoning index.d.ts files as well.
daker
force-pushed
the
refactor-scalarcoloring
branch
from
July 22, 2026 09:35
08c6718 to
1f56ad5
Compare
daker
changed the title
daker
force-pushed
the
refactor-scalarcoloring
branch
from
July 22, 2026 12:29
1f56ad5 to
ff665d8
Compare
finetjul
approved these changes
Jul 22, 2026
finetjul
left a comment
finetjul
left a comment
Member
There was a problem hiding this comment.
LGTM.
Is it a breaking change ? Is the mapper API 100% similar to before ?
Collaborator
Author
I need to assess this, i added a bug fix for #3509 and maybe some methods can surface with this refactor. i will put it on hold |
daker
force-pushed
the
refactor-scalarcoloring
branch
from
July 23, 2026 12:39
ff665d8 to
1f0e6e2
Compare
Member
|
@daker is this ready to merge as a "pure" refactor commit ? |
daker
force-pushed
the
refactor-scalarcoloring
branch
from
August 27, 2026 19:24
1f0e6e2 to
e849b65
Compare
daker
force-pushed
the
refactor-scalarcoloring
branch
from
August 27, 2026 19:28
e849b65 to
74a277a
Compare
Collaborator
Author
|
🎉 This PR is included in version 36.10.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting