chore(ConeSource): add initial resetCamera and render - #3579
Open
Jo-Byr wants to merge 1 commit into
Open
Conversation
Add missing resetCamera and render calls to prevent the cone from clipping into the camera plane intially
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
On initial loading, the cone of SimpleCone example clips into the camera plane.
Results
The cone is properly displayed away from the camera.
Changes
Added a
resetCameraandrendercall after loading the scene.PR and Code Checklist
npm run reformatto have correctly formatted code