feat: ERC-7858 and some optimize #61
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
Signed-off-by: MASDXI <[email protected]>
|
@ADISAKBOONMARK @parametprame check this then i will develop a test for it. |
I will check it today. |
adding logic to the functio that inheritance form the IERC7858
parametprame
approved these changes
Feb 21, 2025
allowing _update function to transfer expired tokenId
|
almost done |
Comment on lines
+50
to
53
| function insert(List storage self, uint256 index, bool check) internal { | ||
| if (check) { | ||
| if (!contains(self, index)) return; | ||
| } |
There was a problem hiding this comment.
Should it be contains(self, index) ?
Comment on lines
+51
to
+52
| if (check) { | ||
| if (!contains(self, index)) return; |
There was a problem hiding this comment.
Should we also add a check flag into remove() and shrink()?
|
I found some bug on ERC-7858Epoch when calling |
Comment on lines
27
to
29
| function insert(uint256 index) public { | ||
| list.insert(index, false); | ||
| } |
There was a problem hiding this comment.
Should it be?
function insert(uint256 index) public {
list.insert(index, true);
}
function insertLazy(uint256 index) public {
list.insert(index, false);
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
focus on NFT and refactor the sorted list to way more efficient