Fix key value in ThreadedRodeo deserialization#44
Open
ytanay wants to merge 1 commit intoKixiron:masterfrom
Open
Fix key value in ThreadedRodeo deserialization#44ytanay wants to merge 1 commit intoKixiron:masterfrom
ytanay wants to merge 1 commit intoKixiron:masterfrom
Conversation
The key is set to be the highest key seen, causing the insertion immediately following the deserialization to create a collision in the string map
Kixiron
reviewed
Sep 18, 2023
|
I ran into this today when adding serialization to an application using this crate. Glad to see there's a fix already! (And, thank you!) |
silvanshade
added a commit
to silvanshade/lasso2
that referenced
this pull request
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The key is set to be the highest key seen during deserialization, causing the insertion immediately following the deserialization to create a collision in the string map