Skip to content

Conversation

@mmhat
Copy link
Contributor

@mmhat mmhat commented Jan 12, 2025

Due to the changed type of GHC.mkNamePprCtxForModule (introduced in https://gitlab.haskell.org/ghc/ghc/-/commit/c5d89412dd21a428709c00499dfa611312ad4735) we need to add an own version of it in the compatibility layer.

I also added an explicit export list for PrintApi.CLI.Cmd.Dump such that only the functions needed by the executables are exported: The motivation for this is a more stable API of that module, and to hide changes to the internals like the changed type of the extractModuleDeclarations function. Please let me know if that is too restrictive.

Copy link
Owner

@Kleidukos Kleidukos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic.

@Kleidukos Kleidukos merged commit 321c188 into Kleidukos:main Jan 12, 2025
19 checks passed
@mmhat mmhat deleted the ghc-9.12.1 branch January 12, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants