Add documentation section about custom handlers#293
Open
lorenabalan wants to merge 2 commits intoKludex:mainfrom
Open
Add documentation section about custom handlers#293lorenabalan wants to merge 2 commits intoKludex:mainfrom
lorenabalan wants to merge 2 commits intoKludex:mainfrom
Conversation
toniton
reviewed
Sep 3, 2023
toniton
left a comment
toniton
left a comment
There was a problem hiding this comment.
Nice work. I found this helpful and I hope the maintainers do as well.
Leaving you some suggestions:
There was a problem hiding this comment.
I would recommend doing this in a separate md file, say custom_handler.md, and trim your custom handler to a minimal implementation that could serve a generic purpose.
Perhaps, you can create a gist for full implementations of specific handlers if you would like to share.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feels like a very underrated feature of
mangumthat deserves it's moment in the sun. ☀️ 🙃 Following up on #288 (comment)There might be some implementation details I didn't get quite right, particularly in the
scopeproperty, so do let me know what's the best way / convention to advertise!Also updated contribution guide while I'm here, as GitHub dropped support for
gitprotocol.