Skip to content
This repository was archived by the owner on Sep 23, 2022. It is now read-only.

Conversation

@wysow
Copy link
Contributor

@wysow wysow commented Apr 4, 2015

fixes #458

@wysow wysow force-pushed the 458-fully-support-valid-names-of-github-repositories branch from 983c9a6 to 67ea643 Compare April 4, 2015 13:50
@wysow
Copy link
Contributor Author

wysow commented Apr 11, 2015

@KnpLabs/knp-team Someone can take a look at this?

@gquemener
Copy link

No test to update?

@docteurklein
Copy link
Contributor

lgtm

@wysow
Copy link
Contributor Author

wysow commented Apr 13, 2015

@gquemener Yep sounds strange but didn't find test about repo name... And as we do not know the valid regex usid by Github, I'm not sure we should add one, what do you think?

@docteurklein
Copy link
Contributor

maybe you can add a test then ?

@wysow
Copy link
Contributor Author

wysow commented Apr 13, 2015

@docteurklein even if we don't know about the valid regex??

@docteurklein
Copy link
Contributor

just test that it behaves like you want it to behave.
Adding a test wont change the fact it accepts some names only, but it'll help understanding later regressions.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fully support valid names of GitHub repositories

4 participants