feat: use default symfony folder structure#473
Merged
garak merged 2 commits intoKnpLabs:masterfrom Apr 13, 2024
Chris53897:feature/move-template-folder
Merged
feat: use default symfony folder structure#473garak merged 2 commits intoKnpLabs:masterfrom Chris53897:feature/move-template-folder
garak merged 2 commits intoKnpLabs:masterfrom
Chris53897:feature/move-template-folder
Conversation
garak
requested changes
Mar 3, 2024
Collaborator
garak
left a comment
garak
left a comment
There was a problem hiding this comment.
It doesn't make much sense to me unless we completely remove the "Resources" folder.
So, please move the config as well
Chris53897
changed the title
Contributor
Author
|
@garak I did now moved the |
garak
approved these changes
Apr 12, 2024
Collaborator
|
This PR is incomplete as it does not change the bundle class to tell Symfony that the new structure is used, causing #476 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#463
https://symfony.com/doc/current/bundles/best_practices.html#directory-structure
I am not sure if there is more todo here.