[Improvement] Add Twig modifier for whitespace trimming #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garak
requested changes
Mar 14, 2025
| @@ -13,70 +13,69 @@ | |||
| #} | |||
| {% if pageCount > 1 %} | |||
| <ul class="uk-pagination uk-flex-center uk-margin-medium-top"> | |||
| {% if previous is defined %} | |||
There was a problem hiding this comment.
This change seems unrelated with the main topic
There was a problem hiding this comment.
It's due to the indentation fix. I've reverted these changes to keep only the ones linked to the whitespace trimming.
GxiGloN
force-pushed
the
bugfix-whitespace-trimming
branch
from
e99e3f9 to
ddb655e
Compare
garak
approved these changes
Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a minor improvement, to avoid adding whitespace in the links anchor text.
Before:
After:
See https://twig.symfony.com/doc/3.x/templates.html#whitespace-control.
I also fixed indentation of the
templates/Pagination/uikit_v3_pagination.html.twigfile. Tell me if that should go in a dedicated PR.