fix nullable declaration for php 8.4#104
Merged
robbieaverill merged 3 commits intoKnpLabs:masterfrom Dec 9, 2024
Merged
Conversation
Collaborator
|
Hi @tacman, I mentioned in #105 that I'd prefer to wait for phpstan to support PHP 8.4. Your latest commit highlights its incompatibility. If you were to revert that commit, we can merge the nullable type change. This would allow you or others to install this package on PHP 8.4 using a What do you think? |
Contributor
Author
|
great idea. I forgot about that option to ignore the php version. |
robbieaverill
approved these changes
Dec 9, 2024
Collaborator
|
This fix is included in version v2.1.1 |
Contributor
Author
|
yep, working fine using the ignore option, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.