Skip to content

11 - forms #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: form-starter
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
157 changes: 154 additions & 3 deletions src/components/rules/CreateItemForm.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,158 @@
import '@/styles/rules/form.css'
import { useEffect, useState } from 'react'
import { RootState, useAppDispatch } from '@/store'
import { addItem, setAddItemRequestStatus } from '@/modules/rules'
import { InputLabel, Input, Button } from '@mui/material'
import AddIcon from '@mui/icons-material/Add'
import { useSelector } from 'react-redux'
import { useNavigate } from 'react-router'
import { RequestStatus } from '@/types'

type FormValues = {
name: string
price: number
linesPerMillisecond: number
}

type FormErrors = {
name?: string
price?: string
linesPerMillisecond?: string
}

export function CreateItemForm() {
const dispatch = useAppDispatch()
const navigate = useNavigate()
const requestStatus = useSelector((state: RootState) => state.rules.addItemRequestStatus)

useEffect(() => {
if (requestStatus === RequestStatus.Succeeded) {
dispatch(setAddItemRequestStatus(RequestStatus.Idle))

navigate('/rules')
}
}, [requestStatus, navigate, dispatch])

const [formValues, setFormValues] = useState<FormValues>({
name: '',
price: 0,
linesPerMillisecond: 0,
})

const [formErrors, setFormErrors] = useState<FormErrors>({})

const handleChange: React.ComponentProps<'input'>['onChange'] = (e) => {
const { name, value } = e.target
setFormValues({
...formValues,
[name]: value,
})
}

const validateForm = () => {
const errors: FormErrors = {}

if (!formValues.name) {
errors.name = 'Name is required'
}

if (!formValues.price) {
errors.price = 'Price is required'
}

if (formValues.price < 0) {
errors.price = 'Price must be a positive number'
}

if (!formValues.linesPerMillisecond) {
errors.linesPerMillisecond = 'Lines per millisecond is required'
}

if (formValues.linesPerMillisecond <= 0) {
errors.linesPerMillisecond = 'Lines per millisecond must be greater than 0'
}

setFormErrors(errors)

return Object.keys(errors).length === 0
}

const handleSubmit: React.ComponentProps<'form'>['onSubmit'] = (e) => {
e.preventDefault()

if (!validateForm()) {
return
}

dispatch(addItem(formValues))
}

return (
<div>
CREATE ITEM FORM
</div>
<form onSubmit={handleSubmit} className="form">
<div>
<InputLabel htmlFor="name">Name *</InputLabel>
<Input
id="name"
className="input"
type="text"
name="name"
placeholder="Item Name"
value={formValues.name}
error={formErrors.name != null}
onChange={handleChange}
/>
{formErrors.name && (
<p className="error-message">
{formErrors.name}
</p>
)}
</div>
<div>
<InputLabel htmlFor="price">Price *</InputLabel>
<Input
id="price"
className="input"
type="number"
name="price"
value={formValues.price}
error={formErrors.price != null}
onChange={handleChange}
/>
{formErrors.price && (
<p className="error-message">
{formErrors.price}
</p>
)}
</div>
<div>
<InputLabel htmlFor="linesPerMillisecond">Lines per millisecond *</InputLabel>
<Input
id="linesPerMillisecond"
className="input"
type="number"
name="linesPerMillisecond"
inputProps={{
step: 0.1,
}}
value={formValues.linesPerMillisecond}
error={formErrors.linesPerMillisecond != null}
onChange={handleChange}
/>
{formErrors.linesPerMillisecond && (
<p className="error-message">
{formErrors.linesPerMillisecond}
</p>
)}
</div>
<Button
type="submit"
variant="contained"
disabled={requestStatus === RequestStatus.Loading}
startIcon={<AddIcon />}
color="primary"
>
Add Item
</Button>
</form>
)
}
173 changes: 170 additions & 3 deletions src/components/rules/EditItemForm.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,174 @@
import '@/styles/rules/form.css'
import { useEffect, useState } from 'react'
import { RootState, useAppDispatch } from '@/store'
import { InputLabel, Input, Button } from '@mui/material'
import SaveIcon from '@mui/icons-material/Save'
import { useSelector } from 'react-redux'
import { useNavigate, useParams } from 'react-router'
import { RequestStatus } from '@/types'
import { setEditItemRequestStatus, editItem } from '@/modules/rules'

type FormValues = {
id: number
name: string
price: number
linesPerMillisecond: number
}

type FormErrors = {
name?: string
price?: string
linesPerMillisecond?: string
}

export function EditItemForm() {
const dispatch = useAppDispatch()
const navigate = useNavigate()
const { id: itemId } = useParams()

const item = useSelector((state: RootState) => {
if (itemId == null) {
return null
}

return state.rules.items.find(item => item.id === Number.parseInt(itemId))
})

const requestStatus = useSelector((state: RootState) => state.rules.editItemRequestStatus)

useEffect(() => {
if (requestStatus === RequestStatus.Succeeded) {
dispatch(setEditItemRequestStatus(RequestStatus.Idle))

navigate('/rules')
}
}, [requestStatus, navigate, dispatch])

const [formValues, setFormValues] = useState<FormValues>({
id: item?.id ?? 0,
name: item?.name ?? '',
price: item?.price ?? 0,
linesPerMillisecond: item?.linesPerMillisecond ?? 0,
})

const [formErrors, setFormErrors] = useState<FormErrors>({})

const handleChange: React.ComponentProps<'input'>['onChange'] = (e) => {
const { name, value } = e.target
setFormValues({
...formValues,
[name]: value,
})
}

const validateForm = () => {
const errors: FormErrors = {}

if (!formValues.name) {
errors.name = 'Name is required'
}

if (!formValues.price) {
errors.price = 'Price is required'
}

if (formValues.price < 0) {
errors.price = 'Price must be a positive number'
}

if (!formValues.linesPerMillisecond) {
errors.linesPerMillisecond = 'Lines per millisecond is required'
}

if (formValues.linesPerMillisecond <= 0) {
errors.linesPerMillisecond = 'Lines per millisecond must be greater than 0'
}

setFormErrors(errors)

return Object.keys(errors).length === 0
}

const handleSubmit: React.ComponentProps<'form'>['onSubmit'] = (e) => {
e.preventDefault()

if (!validateForm()) {
return
}

dispatch(editItem(formValues))
}

if (item == null) {
return <p className="error-message">Item with id: {itemId} not found</p>
}

return (
<div>
EDIT ITEM FORM
</div>
<form onSubmit={handleSubmit} className="form">
<div>
<InputLabel htmlFor="name">Name *</InputLabel>
<Input
id="name"
className="input"
type="text"
name="name"
placeholder="Item Name"
value={formValues.name}
error={formErrors.name != null}
onChange={handleChange}
/>
{formErrors.name && (
<p className="error-message">
{formErrors.name}
</p>
)}
</div>
<div>
<InputLabel htmlFor="price">Price *</InputLabel>
<Input
id="price"
className="input"
type="number"
name="price"
value={formValues.price}
error={formErrors.price != null}
onChange={handleChange}
/>
{formErrors.price && (
<p className="error-message">
{formErrors.price}
</p>
)}
</div>
<div>
<InputLabel htmlFor="linesPerMillisecond">Lines per millisecond *</InputLabel>
<Input
id="linesPerMillisecond"
className="input"
type="number"
name="linesPerMillisecond"
inputProps={{
step: 0.1,
}}
value={formValues.linesPerMillisecond}
error={formErrors.linesPerMillisecond != null}
onChange={handleChange}
/>
{formErrors.linesPerMillisecond && (
<p className="error-message">
{formErrors.linesPerMillisecond}
</p>
)}
</div>
<Button
type="submit"
variant="contained"
disabled={requestStatus === RequestStatus.Loading}
startIcon={<SaveIcon />}
color="primary"
>
Save
</Button>
</form>
)
}
15 changes: 13 additions & 2 deletions src/components/rules/ItemsList.tsx
Original file line number Diff line number Diff line change
@@ -1,16 +1,25 @@
import { RootState } from '@/store'
import { RootState, useAppDispatch } from '@/store'
import numberFormat from '@/tests/numberFormat'
import { TableContainer, Paper, Table, TableHead, TableRow, TableCell, TableBody, IconButton, Fab } from '@mui/material'
import EditIcon from '@mui/icons-material/Edit'
import DeleteIcon from '@mui/icons-material/Delete'
import AddIcon from '@mui/icons-material/Add'
import { useSelector } from 'react-redux'
import { useNavigate } from 'react-router'
import { deleteItem } from '@/modules/rules'
import { Item, RequestStatus } from '@/types'

export function ItemsList() {
const items = useSelector((state: RootState) => state.rules.items)
const dispatch = useAppDispatch()
const navigate = useNavigate()

const items = useSelector((state: RootState) => state.rules.items)
const requestStatus = useSelector((state: RootState) => state.rules.deleteItemRequestStatus)

const handleDelete = (item: Item) => {
dispatch(deleteItem(item.id))
}

return (
<>
<TableContainer component={Paper}>
Expand Down Expand Up @@ -39,6 +48,8 @@ export function ItemsList() {
<IconButton
color="error"
aria-label="delete"
disabled={requestStatus === RequestStatus.Loading}
onClick={() => handleDelete(item)}
>
<DeleteIcon />
</IconButton>
Expand Down
Loading