Skip to content

Fix native shortcut modifier matching#570

Open
Qwinty wants to merge 1 commit into
Kochava-Studios:mainfrom
Qwinty:fix/native-shortcut-exact-modifiers
Open

Fix native shortcut modifier matching#570
Qwinty wants to merge 1 commit into
Kochava-Studios:mainfrom
Qwinty:fix/native-shortcut-exact-modifiers

Conversation

@Qwinty

@Qwinty Qwinty commented May 15, 2026

Copy link
Copy Markdown

Closes #569.

Summary

  • require exact modifier sets for native modifier+key and modifier-only combo shortcuts
  • delay multi-modifier combo activation briefly so Alt+Tab/other key chords can cancel it before callbacks fire
  • release active modifier-only shortcuts when they become part of a chord
  • make keymonitor tests platform-aware and cover the Windows Alt+Win regression cases

Verification

  • npm test -- tests/unit/main/keymonitor.test.ts
  • npx eslint src/main/keymonitor.ts tests/unit/main/keymonitor.test.ts
  • npx vue-tsc --noEmit --project tsconfig.lint.json
  • git diff --check

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Windows native Alt+Win dictation shortcut can fire during other Alt combos

2 participants