Skip to content

Add support for MG-GPO02Z / Sparkelec SGPO2TZ #12586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KablammoNick wants to merge 4 commits into
base: master
Choose a base branch
from
+265 −1
Draft

Add support for MG-GPO02Z / Sparkelec SGPO2TZ #12586

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e41f43f
Add support for MG-GPO02Z / Sparkelec SGPO2TZ
KablammoNick Jun 29, 2026
78b0d81
Update makegood.ts
KablammoNick Jun 30, 2026
62421e8
[autofix.ci] apply automated fixes
autofix-ci[bot] Jun 30, 2026
406a4b3
Update makegood.ts
KablammoNick Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
266 changes: 265 additions & 1 deletion src/devices/makegood.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,98 @@
import * as fz from "../converters/fromZigbee";
import * as tz from "../converters/toZigbee";
import * as e from "../lib/exposes";
import * as m from "../lib/modernExtend";
import * as reporting from "../lib/reporting";
import * as tuya from "../lib/tuya";
import type {DefinitionWithExtend} from "../lib/types";
import type {DefinitionWithExtend, KeyValueAny, Tz} from "../lib/types";

const ea = e.access;

// --- MG-GPO02Z / SGPO2TZ helpers ---

const powerOnBehaviorConverter = tuya.valueConverterBasic.lookup({
power_off: tuya.enum(0),
power_on: tuya.enum(1),
last: tuya.enum(2),
});

const childLockConverter = tuya.valueConverterBasic.lookup({LOCK: true, UNLOCK: false});

const countdownConverter = {
from: (value: unknown) => (value == null || value === false ? 0 : Number(value)),
to: (value: unknown) => Number(value),
};

const energyConverter = {
from: (value: unknown, meta: {state?: {energy?: number}}) => {
if (value == null) return 0;
const newEnergy = tuya.valueConverter.divideBy1000.from(value as number);
const lastEnergy = meta.state?.energy ?? 0;
if (newEnergy > 0) return Number((lastEnergy + newEnergy).toFixed(3));
return lastEnergy;
},
to: (value: unknown) => value,
};

const backlightColorConverter = {
from(value: unknown) {
if (!value) return null;
const buf = Buffer.isBuffer(value) ? value : Buffer.from(value as string);
if (buf.length !== 21) return null;
const parseSocket = (o: number) => ({
onBrightness: buf[o],
onHue: buf.readUInt16BE(o + 1),
onSaturation: buf.readUInt16BE(o + 3),
offBrightness: buf[o + 5],
offHue: buf.readUInt16BE(o + 6),
offSaturation: buf.readUInt16BE(o + 8),
});
return {
mode: buf[0] === 1 ? "multi" : "single",
socket1: parseSocket(1),
socket2: parseSocket(11),
};
},
to(value: unknown) {
return value;
},
};

const backlightColorToZigbee: Tz.Converter = {
key: ["backlight_color"],
convertSet: async (entity, key, value, meta) => {
let cfg = value as KeyValueAny;
if (typeof value === "string") {
try {
cfg = JSON.parse(value);
} catch {
throw new Error("backlight_color must be valid JSON");
}
}

const buf = Buffer.alloc(21);
buf[0] = cfg.mode === "multi" ? 1 : 0;

const clamp = (v: unknown, min: number, max: number) => Math.max(min, Math.min(max, Number(v) || 0));

const writeSocket = (s: KeyValueAny, o: number) => {
buf[o] = clamp(s.onBrightness ?? 100, 0, 100);
buf.writeUInt16BE(clamp(s.onHue ?? 0, 0, 360), o + 1);
buf.writeUInt16BE(clamp(s.onSaturation ?? 1000, 0, 1000), o + 3);
buf[o + 5] = clamp(s.offBrightness ?? 10, 0, 100);
buf.writeUInt16BE(clamp(s.offHue ?? 240, 0, 360), o + 6);
buf.writeUInt16BE(clamp(s.offSaturation ?? 1000, 0, 1000), o + 8);
};

writeSocket(cfg.socket1 ?? {}, 1);
writeSocket(cfg.socket2 ?? {}, 11);

await tuya.sendDataPointRaw(entity, 107, [buf]);

Check failure on line 90 in src/devices/makegood.ts

View workflow job for this annotation

GitHub Actions / ci 

Type 'Buffer<ArrayBuffer>' is not assignable to type 'number'.
return {state: {backlight_color: cfg}};
},
} satisfies Tz.Converter;

// --- Definitions ---

export const definitions: DefinitionWithExtend[] = [
{
Expand Down Expand Up @@ -84,4 +173,179 @@
multiEndpointSkip: ["power", "current", "voltage", "energy"],
},
},
{
fingerprint: tuya.fingerprint("TS0601", ["_TZE200_lq0ffndf"]),
model: "MG-GPO02Z",
vendor: "MakeGood",
description: "Dual GPO with energy monitoring and RGB backlights",
whiteLabel: [tuya.whitelabel("Sparkelec", "_TZE200_lq0ffndf", "Dual GPO with energy monitoring and RGB backlights", ["_TZE200_lq0ffndf"])],
configure: tuya.configureMagicPacket,
fromZigbee: [tuya.fz.datapoints],
toZigbee: [backlightColorToZigbee, tuya.tz.datapoints],
endpoint: () => ({l1: 1, l2: 1}),
exposes: [
tuya.exposes.switch().withEndpoint("l1"),
tuya.exposes.switch().withEndpoint("l2"),

e
.numeric("countdown_l1", ea.STATE_SET)
.withUnit("s")
.withValueMin(0)
.withValueMax(43200)
.withDescription("Auto-off/on countdown timer for socket 1"),
e
.numeric("countdown_l2", ea.STATE_SET)
.withUnit("s")
.withValueMin(0)
.withValueMax(43200)
.withDescription("Auto-off/on countdown timer for socket 2"),

e
.enum("power_on_behavior", ea.STATE_SET, ["power_off", "power_on", "last"])
.withEndpoint("l1")
.withDescription("Behavior when power is restored — socket 1"),
e
.enum("power_on_behavior", ea.STATE_SET, ["power_off", "power_on", "last"])
.withEndpoint("l2")
.withDescription("Behavior when power is restored — socket 2"),

e.binary("all_on_off", ea.STATE_SET, "ON", "OFF").withDescription("Master switch — all sockets simultaneously"),

e.numeric("power", ea.STATE).withUnit("W").withDescription("Instantaneous power"),
e.numeric("current", ea.STATE).withUnit("A").withDescription("Instantaneous current"),
e.numeric("voltage", ea.STATE).withUnit("V").withDescription("Instantaneous voltage"),
e.numeric("energy", ea.STATE).withUnit("kWh").withDescription("Cumulative energy consumption"),

tuya.exposes.backlightModeOffOn(),

e
.composite("backlight_color", "backlight_color", ea.STATE_SET)
.withDescription("Backlight color config is only meaningful when backlight mode is ON")
.withFeature(
e
.enum("mode", ea.STATE_SET, ["single", "multi"])
.withDescription("single: one color per socket; multi: separate on/off colors per socket"),
)
.withFeature(
e
.composite("socket1", "socket1", ea.STATE_SET)
.withDescription("Socket 1 LED")
.withFeature(
e
.numeric("onBrightness", ea.STATE_SET)
.withValueMin(0)
.withValueMax(100)
.withUnit("%")
.withDescription("Brightness when socket is ON"),
)
.withFeature(
e
.numeric("onHue", ea.STATE_SET)
.withValueMin(0)
.withValueMax(360)
.withDescription("Hue (0=red, 60=yellow, 120=green, 180=cyan, 240=blue, 300=magenta, 360=purple)"),
)
.withFeature(
e
.numeric("onSaturation", ea.STATE_SET)
.withValueMin(0)
.withValueMax(1000)
.withDescription("Saturation when ON (0=white, 1000=full color)"),
)
.withFeature(
e
.numeric("offBrightness", ea.STATE_SET)
.withValueMin(0)
.withValueMax(100)
.withUnit("%")
.withDescription("Brightness when socket is OFF — backlight mode ON only"),
)
.withFeature(
e
.numeric("offHue", ea.STATE_SET)
.withValueMin(0)
.withValueMax(360)
.withDescription("Hue when OFF — multi-color mode only"),
)
.withFeature(
e
.numeric("offSaturation", ea.STATE_SET)
.withValueMin(0)
.withValueMax(1000)
.withDescription("Saturation when OFF — multi-color mode only"),
),
)
.withFeature(
e
.composite("socket2", "socket2", ea.STATE_SET)
.withDescription("Socket 2 LED")
.withFeature(
e
.numeric("onBrightness", ea.STATE_SET)
.withValueMin(0)
.withValueMax(100)
.withUnit("%")
.withDescription("Brightness when socket is ON"),
)
.withFeature(
e
.numeric("onHue", ea.STATE_SET)
.withValueMin(0)
.withValueMax(360)
.withDescription("Hue (0=red, 60=yellow, 120=green, 180=cyan, 240=blue, 300=magenta, 360=purple)"),
)
.withFeature(
e
.numeric("onSaturation", ea.STATE_SET)
.withValueMin(0)
.withValueMax(1000)
.withDescription("Saturation when ON (0=white, 1000=full color)"),
)
.withFeature(
e
.numeric("offBrightness", ea.STATE_SET)
.withValueMin(0)
.withValueMax(100)
.withUnit("%")
.withDescription("Brightness when socket is OFF — backlight mode ON only"),
)
.withFeature(
e
.numeric("offHue", ea.STATE_SET)
.withValueMin(0)
.withValueMax(360)
.withDescription("Hue when OFF — multi-color mode only"),
)
.withFeature(
e
.numeric("offSaturation", ea.STATE_SET)
.withValueMin(0)
.withValueMax(1000)
.withDescription("Saturation when OFF — multi-color mode only"),
),
),

e.binary("child_lock", ea.STATE_SET, "LOCK", "UNLOCK").withDescription("Prevent physical control of the sockets"),
],
meta: {
multiEndpoint: true,
multiEndpointSkip: ["power", "current", "voltage", "energy", "all_on_off"],
tuyaDatapoints: [
[1, "state_l1", tuya.valueConverter.onOff],
[2, "state_l2", tuya.valueConverter.onOff],
[7, "countdown_l1", countdownConverter],
[8, "countdown_l2", countdownConverter],
[16, "backlight_mode", tuya.valueConverter.onOff],
[20, "energy", energyConverter],
[21, "current", tuya.valueConverter.divideBy1000],
[22, "power", tuya.valueConverter.divideBy10],
[23, "voltage", tuya.valueConverter.divideBy10],
[29, "power_on_behavior_l1", powerOnBehaviorConverter],
[30, "power_on_behavior_l2", powerOnBehaviorConverter],
[101, "child_lock", childLockConverter],
[107, "backlight_color", backlightColorConverter],
[136, "all_on_off", tuya.valueConverter.onOff],
],
},
},
];
Loading