Skip to content

feat: Expose action parameters: group, level, rate, step size and transition time#12683

Open
andrei-lazarov wants to merge 7 commits into
Koenkk:masterfrom
andrei-lazarov:actions
Open

feat: Expose action parameters: group, level, rate, step size and transition time#12683
andrei-lazarov wants to merge 7 commits into
Koenkk:masterfrom
andrei-lazarov:actions

Conversation

@andrei-lazarov

Copy link
Copy Markdown
Contributor

See each commit for easier review

This pull request exposes the following entities for remotes that use standard functions m.commandsCluster():

  • action_group
  • action_level
  • action_rate
  • action_step_size
  • action_transition_time

I covered only OnOff and LevelControl clusters.
More should be aded in the future, for ColorControl, Scenes, WindowCovering: action_hue, action_direction, action_saturation, action_color etc.

These parameters were already published to MQTT, just not exposed.
Should be no functionality changes, just easier use. It makes them show up in WF, HA and docs.

I triggered a docgen to check the results: andrei-lazarov/zigbee2mqtt.io@6daf67e

And of course I tested locally

@andrei-lazarov

Copy link
Copy Markdown
Contributor Author

Also I don't like how they are separate entities. Maybe we can rework in Z2M 3.0.0?

"voltage": 2500,
"action": "off",
"action_group": 21658     
"voltage": 2500,
"action": {
    "command": "off",
    "group": 21658
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant