Add FDS315 Owon fall sensor#9488
Merged
Merged
Conversation
Koenkk
reviewed
Jun 13, 2025
| }, | ||
| }; | ||
|
|
||
| export const owonFds315SetFallSettings: Tz.Converter = { |
Owner
There was a problem hiding this comment.
Please move both the fromZigbee and toZigbee changes into owon.ts under a tzLocal/fzLocal, example:
Koenkk
reviewed
Jun 13, 2025
| 0: "Unoccupied", | ||
| 1: "Occupied", | ||
| 2: "Sitting", | ||
| 3: "On the bed", |
Owner
There was a problem hiding this comment.
Suggested change
| 3: "On the bed", | |
| 3: "on_the_bed", |
Make all snake_case
Koenkk
reviewed
Jun 13, 2025
| const code = data.status; | ||
| result.status = statusMapping[code] || `Unknown (${code})`; | ||
| } | ||
| if (data.breathingRate !== undefined) result.breathingRate = data.breathingRate; |
Owner
There was a problem hiding this comment.
Suggested change
| if (data.breathingRate !== undefined) result.breathingRate = data.breathingRate; | |
| if (data.breathingRate !== undefined) result.breathing_rate = data.breathingRate; |
Also make all of these snake_case
Koenkk
reviewed
Jun 16, 2025
| exposes: [ | ||
| e.enum("status", ea.STATE, ["unoccupied", "occupied", "sitting", "on_the_bed", "low_posture", "falling"]), | ||
| e.numeric("breathing_rate", ea.STATE).withUnit("breaths/min").withDescription("Breathing rate."), | ||
| e.numeric("locationX", ea.STATE).withUnit("cm").withDescription("X coordinate of human activity."), |
Owner
There was a problem hiding this comment.
Suggested change
| e.numeric("locationX", ea.STATE).withUnit("cm").withDescription("X coordinate of human activity."), | |
| e.numeric("location_x", ea.STATE).withUnit("cm").withDescription("X coordinate of human activity."), |
(same for location Y)
Koenkk
reviewed
Jun 16, 2025
| result.status = status_mapping[code] || `Unknown (${code})`; | ||
| } | ||
| if (data.breathing_rate !== undefined) result.breathing_rate = data.breathing_rate; | ||
| if (data.locationX !== undefined) result.locationX = data.locationX; |
Owner
There was a problem hiding this comment.
Suggested change
| if (data.locationX !== undefined) result.locationX = data.locationX; | |
| if (data.locationX !== undefined) result.location_x = data.locationX; |
(same for location Y)
Owner
|
Thanks! |
rohankapoorcom
pushed a commit
to rohankapoorcom/zigbee-herdsman-converters
that referenced
this pull request
Jun 20, 2025
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
SimplaHome
pushed a commit
to SimplaHome/zigbee-herdsman-converters
that referenced
this pull request
Aug 15, 2025
Co-authored-by: Koen Kanters <koenkanters94@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add converter together with from and to for OWON FDS315 drop sensor