-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for ingress multiplath #22580
Conversation
I already trigger a chart release before seeing this PR (run), can this PR go to dev? |
Yes, it can be put to dev, no issues. changed. The release was correct only at 50%. which doesn't exist... 😮💨 |
@jlpedrosa I removed that release, I only want the real z2m releases there. Is that a problem? |
yes, that is the URL included in the index, so that is were the charts gets downloaded. I can change the release name so it matches the one you already creates, not sure if it will fail or will add it to yours. |
@Koenkk I have been banging my head against the wall with this for a long time. helm-releaser does not support it append the chart to an existing release. I created a patch to fix it upstream. They don't seem to be reviewing PR at all: helm/chart-releaser#407 Have the two tags in this repo. |
I guess this option makes the most sense. We can trigger an update similar as we do for the HASS addon: zigbee2mqtt/.github/workflows/ci.yml Line 87 in c02c61d
|
Hi, what ever you want, this is how I set it up for another OSS project: https://github.com/unpoller/helm-chart/ Let me know when you've created the repo. If you want to give me write-access, I can help you maintain it. In any case, let me know when you've created the repo. Remeber the gh-pages branch. |
If we don't want multiple tags in this repo, a separate repo is the only solution, right? |
There's another way that in theory can be used which is the github packages (not releases) and use it as OCI helm repository. I am not positive, but I think it has the drawback of renovate/dependabot not being able to "crawl" the repo (because there's no index.yaml), note I am not positive. Other option is to create the index.yaml "manually/script" and upload thr file to the exisisting release. So yes, there are solutions, but require a decent amount of time.to get it working. |
Then let's go for the separate repo, added you to https://github.com/Koenkk/zigbee2mqtt-chart |
Hi @Koenkk
I thing the chart is ready to be released, i did the full process on my fork.
Index is available (in my fork) : https://jlpedrosa.github.io/zigbee2mqtt/index.yaml
Package can be downloaded and installed:
Deployment seems to work just fine: