Fixes/hstream: Add series grouping#1333
Conversation
Replace keiyoushi.utils imports with Aniyomi-compatible equivalents: - parseAs → eu.kanade.tachiyomi.util.parseAs - getPreferencesLazy → Injekt lazy SharedPreferences pattern - addSwitchPreference → manual SwitchPreferenceCompat pattern Fix SharedPreferences extension method calls (getBoolean, getString, edit) Add kotlin-test and okhttp test dependencies Move test file from src/test/ to test/kotlin/ for correct source set
- Changed ungrouped path selector from fa-upload to fa-regular fa-calendar - Added release date fetching in grouped path for all episode paths - Replaced all date_upload = 0L assignments with actual release date lookups - Episode dates now reflect original release/air date, not site upload date
… date text is inside a <p> child element within the <a> tag, so ownText() returns empty. text() correctly includes descendant text.
|
Why Tests, There isn't any need for that. |
I can remove them if it's really a problem, otherwise theyre harmless I'd think |
There isn't any need for them so might as well remove them from build.gradle as well |
Done. |
|
Bump in case maintainers didn't see my edit |
|
Have You check everything, Search, filters, video list, episode list and That by enabling group it doesn't duplicate entries. Plus only check the task in hecklist that you did there isn't any need to check them all |
I mean, yes due to the way it works there's no way it could duplicate entries. I'll double-check and reply again if everything is good. |
- Fixed null safety in HstreamFilters.kt (removed !! operators) - Improved error messages (XSRF-TOKEN, date parsing) - Clarified 'Group by series' preference summary - Added '(fallback)' indicator for single-episode mode - Added Toast for ActivityNotFoundException - Added episode sort order preference - Used robust extractEpisodeNumber() for URL parsing - Deduplication fix for episode grouping - Fixed context reference in HstreamUrlActivity (ActivityNotFoundException handler)
Everything is checked and confirmed. Ready to merge. |
2 participants
Checklist:
extVersionCodevalue inbuild.gradlefor individual extensionsoverrideVersionCodeorbaseVersionCodeas needed for all multisrc extensionsisNsfw = trueflag inbuild.gradlewhen appropriateidif a source's name or language were changedweb_hi_res_512.pngwhen adding a new extensionThis PR aims to add episode grouping to hstream. This is a toggleable option so users can switch back to the old format if they wish.
Also fixed episode dates to use the release date instead of the site upload date.
This will be the primary repository for my PRs moving forward in lieu of Yuzono due to much faster PR review times and overall higher quality code.