Skip to content

Create About2 section #27

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

AmirAgassi
Copy link
Member

@AmirAgassi AmirAgassi commented Apr 26, 2025

Description

Added a new About2 section
TODO: Responsiveness

Linked Issues

Testing

image

Reviewer Checklist

When reviewing this PR, make sure to keep the following in mind:

  • This PR should not span too many unrelated tickets or changes.
    • If it does, consider breaking it up into smaller PRs.
  • Is the code coverage acceptable?
  • Does the preview deployment work as expected?
  • Does this PR pass all tests?
  • Does this PR have a clear list of issues that it closes?
  • Does the code follow the style guidelines of the project?

Author Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@AmirAgassi AmirAgassi added enhancement New feature or request frontend Related to the frontend of the project labels Apr 26, 2025
@AmirAgassi AmirAgassi added this to the M0: Anno milestone Apr 26, 2025
@AmirAgassi AmirAgassi self-assigned this Apr 26, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new About2 section to the landing page to enrich the site content. Key changes include:

  • Importing and rendering new About and About2 components in the landing page.
  • Creating a new About2 section that integrates a Spline scene with responsive design.
  • Updating component and asset indexes to export the new sections and knot animation assets.

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

File Description
src/pages/Landing.tsx Added imports and component instantiation for About and About2 sections.
src/components/sections/about2.section.tsx Introduced the new About2 section with Spline integration and styled layout.
src/components/index.ts Updated file index to export the About and About2 components.
src/assets/index.ts Added new knot animation assets for use within the sections.
Comments suppressed due to low confidence (2)

src/components/sections/about2.section.tsx:100

  • Consider using the imported 'Knot1' asset from src/assets/index.ts instead of a hardcoded path to ensure consistency across the codebase.
<Image src="/src/assets/animations/knot_1.svg" alt="Knot decorative element 1" position="absolute" top="-90%" left="-85%" zIndex={-1} boxSize="490px" />

src/components/sections/about2.section.tsx:109

  • Consider using the imported 'Knot8' asset from src/assets/index.ts instead of a hardcoded string to keep asset management consistent.
<Image src="/src/assets/animations/knot_8.svg" alt="Knot decorative element 4" position="absolute" bottom="-120%" right="60%" zIndex={-1} boxSize="290px" />

@AmirAgassi AmirAgassi force-pushed the feat/8/add-second-about-section branch from af3dff2 to c03540b Compare April 26, 2025 16:43
@AmirAgassi AmirAgassi marked this pull request as ready for review April 27, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to the frontend of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the second about section for the landing page
2 participants