-
Notifications
You must be signed in to change notification settings - Fork 0
Create About2 section #27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a new About2 section to the landing page to enrich the site content. Key changes include:
- Importing and rendering new About and About2 components in the landing page.
- Creating a new About2 section that integrates a Spline scene with responsive design.
- Updating component and asset indexes to export the new sections and knot animation assets.
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
File | Description |
---|---|
src/pages/Landing.tsx | Added imports and component instantiation for About and About2 sections. |
src/components/sections/about2.section.tsx | Introduced the new About2 section with Spline integration and styled layout. |
src/components/index.ts | Updated file index to export the About and About2 components. |
src/assets/index.ts | Added new knot animation assets for use within the sections. |
Comments suppressed due to low confidence (2)
src/components/sections/about2.section.tsx:100
- Consider using the imported 'Knot1' asset from src/assets/index.ts instead of a hardcoded path to ensure consistency across the codebase.
<Image src="/src/assets/animations/knot_1.svg" alt="Knot decorative element 1" position="absolute" top="-90%" left="-85%" zIndex={-1} boxSize="490px" />
src/components/sections/about2.section.tsx:109
- Consider using the imported 'Knot8' asset from src/assets/index.ts instead of a hardcoded string to keep asset management consistent.
<Image src="/src/assets/animations/knot_8.svg" alt="Knot decorative element 4" position="absolute" bottom="-120%" right="60%" zIndex={-1} boxSize="290px" />
af3dff2
to
c03540b
Compare
Description
Added a new About2 section
TODO: Responsiveness
Linked Issues
Testing
Reviewer Checklist
When reviewing this PR, make sure to keep the following in mind:
Author Checklist
Before opening this PR, make sure the PR:
Additionally, make sure that: