Skip to content

Feat/18/navbar #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 27, 2025
Merged

Feat/18/navbar #28

merged 33 commits into from
Apr 27, 2025

Conversation

GabeDiniz
Copy link
Contributor

@GabeDiniz GabeDiniz commented Apr 26, 2025

Description

Responsive navbar with expanding menu animation for mobile.

Linked Issues

Testing

  • Not round here partner

Reviewer Checklist

When reviewing this PR, make sure to keep the following in mind:

  • This PR should not span too many unrelated tickets or changes.
    • If it does, consider breaking it up into smaller PRs.
  • Is the code coverage acceptable?
  • Does the preview deployment work as expected?
  • Does this PR pass all tests?
  • Does this PR have a clear list of issues that it closes?
  • Does the code follow the style guidelines of the project?

Author Checklist

Before opening this PR, make sure the PR:

  • Has an assignee or group of assignees.
  • Has a reviewer or a group of reviewers.
  • Is labelled properly.
  • Has an assigned milestone.

Additionally, make sure that:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • Any dependent changes have been merged and published in downstream modules.

@GabeDiniz GabeDiniz added enhancement New feature or request frontend Related to the frontend of the project labels Apr 26, 2025
@GabeDiniz GabeDiniz added this to the M0: Anno milestone Apr 26, 2025
@GabeDiniz GabeDiniz self-assigned this Apr 26, 2025
@juancwu
Copy link

juancwu commented Apr 26, 2025

image Screenshot 2025-04-26 at 5 31 48 PM Screenshot 2025-04-26 at 5 32 03 PM

I find the links in the navbar really hard to read so we should go for a lighter colour

@juancwu
Copy link

juancwu commented Apr 27, 2025

image

Logo should be white and the buttons should be uppercase. Other than that, everything lgtm

@GabeDiniz
Copy link
Contributor Author

image Logo should be white and the buttons should be uppercase. Other than that, everything lgtm

Good catch, fixed.

@GabeDiniz GabeDiniz merged commit 0dd5ad2 into main Apr 27, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Related to the frontend of the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the navbar component
2 participants