Skip to content

Conversation

@ashman1984
Copy link
Contributor

What this PR does / why we need it:

Adds migrations.ttlSecondsAfterFinished as an option in the chart template for allowing removal of migrations containers after a specified time.

The use of ttlSecondsAfterFinished was first discussed here, however the TTL mechanism was in beta at the time.

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • [] PR is based off the current tip of the main branch.
  • Changes are documented under the "Unreleased" header in CHANGELOG.md
  • New or modified sections of values.yaml are documented in the README.md
  • Commits follow the Kong commit message guidelines

@ashman1984 ashman1984 requested a review from a team as a code owner November 26, 2024 02:37
@CLAassistant
Copy link

CLAassistant commented Nov 26, 2024

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@ashman1984 ashman1984 closed this Nov 28, 2024
@ashman1984 ashman1984 deleted the feat-add-ttlSecondsAfterFinished branch November 28, 2024 06:32
@ashman1984 ashman1984 restored the feat-add-ttlSecondsAfterFinished branch November 28, 2024 06:46
@ashman1984 ashman1984 reopened this Nov 28, 2024
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. Generally this looks good.

Since we're adding a possible value to be set in values.yaml can you please add that under

# Enable/disable migration jobs, and set annotations for them
migrations:
and in
| migrations.preUpgrade | Run "kong migrations up" jobs | `true` |
| migrations.postUpgrade | Run "kong migrations finish" jobs | `true` |
| migrations.annotations | Annotations for migration job pods | `{"sidecar.istio.io/inject": "false" |
| migrations.jobAnnotations | Additional annotations for migration jobs | `{}` |
| migrations.backoffLimit | Override the system backoffLimit | `{}` |

@pmalek
Copy link
Member

pmalek commented Nov 28, 2024

Please also make sure to sign the CLA so that the PR can merge.

@pmalek
Copy link
Member

pmalek commented Nov 29, 2024

Thanks for the contribution @ashman1984 🙇

@pmalek pmalek merged commit 2e95d00 into Kong:main Nov 29, 2024
32 checks passed
@ashman1984 ashman1984 deleted the feat-add-ttlSecondsAfterFinished branch December 3, 2024 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants