-
Notifications
You must be signed in to change notification settings - Fork 494
feat(conf): Add migrations.ttlSecondsAfterFinished to chart template #1174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(conf): Add migrations.ttlSecondsAfterFinished to chart template #1174
Conversation
|
|
pmalek
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. Generally this looks good.
Since we're adding a possible value to be set in values.yaml can you please add that under
charts/charts/kong/values.yaml
Lines 469 to 470 in 28af4cb
| # Enable/disable migration jobs, and set annotations for them | |
| migrations: |
Lines 621 to 625 in 28af4cb
| | migrations.preUpgrade | Run "kong migrations up" jobs | `true` | | |
| | migrations.postUpgrade | Run "kong migrations finish" jobs | `true` | | |
| | migrations.annotations | Annotations for migration job pods | `{"sidecar.istio.io/inject": "false" | | |
| | migrations.jobAnnotations | Additional annotations for migration jobs | `{}` | | |
| | migrations.backoffLimit | Override the system backoffLimit | `{}` | |
|
Please also make sure to sign the CLA so that the PR can merge. |
|
Thanks for the contribution @ashman1984 🙇 |
What this PR does / why we need it:
Adds
migrations.ttlSecondsAfterFinishedas an option in the chart template for allowing removal of migrations containers after a specified time.The use of ttlSecondsAfterFinished was first discussed here, however the TTL mechanism was in beta at the time.
Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
mainbranch.