feat(deployment) add template rendering to initContainers #826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pmalek
reviewed
Sep 1, 2025
Member
pmalek
left a comment
pmalek
left a comment
There was a problem hiding this comment.
Hi @jeroen-vankelecom 👋
This change looks good, are you still interested in contributing this? If so, then please rebase on most recent main tip and please add an exemplar values.yaml in https://github.com/Kong/charts/tree/main/charts/kong/ci so that the test harness can test this on CI and we can see an actual usage of this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allow users to pass helm templates (e.g. for the image name) when definining additional initContainers
Which issue this PR fixes
Special notes for your reviewer:
None
Checklist
mainbranch.